-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add automated tests for presearch and algorand #3030
add automated tests for presearch and algorand #3030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you use the correct SSH key type? You should use the ssh-ed25519 not the normal one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this package may help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and please notice that the current logic overwrite the provided config if one of the mnemonic
, network
, or ssh_key
are not provided in env.
we may change that logic to get the missing only
form config.json or make sure to provide all configs in one place
also if we keep this logic, we have to export all config if we want to read the ssh_key from .ssh dir
tfgrid-sdk-ts/packages/grid_client/tests/client_loader.ts
Lines 15 to 26 in 828f0a0
if (!network || !mnemonic || !ssh_key) { | |
console.log("Credentials not all found in env variables. Loading all credentials from default config.json..."); | |
config = JSON.parse(fs.readFileSync(path.join(__dirname, "./config.json"), "utf-8")); | |
} else { | |
console.log("Credentials loaded from env variables..."); | |
config = { | |
network: network, | |
mnemonic: mnemonic, | |
storeSecret: storeSecret, | |
ssh_key: ssh_key, | |
}; | |
} |
… only get non null values, and added the timeout duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please validate if the machine that runs these tests has ygg installed and configured, |
As we discussed, I'm going to mention that on the Readme to make sure that ygg is needed to be installed with all of the other needed packages. Also, I added a few tries in the trim of the Docker hash: a3b4659. And I have added the required notes here: e8e35cb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! @A-Harby
Description
Add the automated tests for algorand and presearch application, (following same code struture as #2890).
The tests are different in that they ssh to the deployed VM and assert that the application is running with the correct version and network.