Support multiple stacks per network in gird client #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sendGetRequest to sendRequest and use fetch instead of axios. - replace serviceUrl and serviceName with getters - add update method that uses URL setter - Make all IServiceBase classes take an optional options on their contractor, add error handling for side effect - Grouped all RMB properties to RMB to RMBProps - Feat: - add stats monitor class that monitors stats service - add activation monitor class that monitor activation service
it is class managing service URLs with liveness checking <pick the first reachable endpoint for each service> - Define retries and silent mode settings - Implement constructor to handle StackManagerOptions - Add private handleErrorsOnSilentMode method for error handling based on silent mode - Implement getAvailableStack method to find reachable service URL - Implement getAvailableServicesStack method to fetch and store available service URLs for all services
…urn undefined or emptystring remove debug lines
…nect and disconnect
…into development_monitoring__stacks
…tech/tfgrid-sdk-ts into development_monitoring__stacks_gridclient
0oM4R
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
mohamedamer453 and
samaradel
as code owners
packages/grid_client/src/client.ts
Outdated
Comment on lines
109
to
111
| async setServiceURLs(): Promise<void> { | ||
| await getAvailableURLs(this.clientOptions); | ||
| } |
There was a problem hiding this comment.
what is the added value of this method?
amiraabouhadid
changed the title
…into development_monitoring__stacks_gridclient
Comment on lines
95
to
123
| */ | ||
| export async function getAvailableURLs(clientOptions: ClientOptions) { | ||
| const { proxyURL, relayURL, substrateURL, graphqlURL, activationURL, network } = clientOptions; | ||
| const currentURLs = { proxyURL, relayURL, substrateURL, graphqlURL, activationURL }; | ||
| const base = network === NetworkEnv.main ? "grid.tf" : `${network}.grid.tf`; | ||
| const URLS = { | ||
| relayURL: [`wss://relay.${base}`, `wss://relay.02.${base}`], | ||
| proxyURL: [`https://gridproxy.${base}`, `https://gridproxy.02.${base}`], | ||
| activationURL: [ | ||
| `https://activation.${base}/activation/activate`, | ||
| `https://activation.02.${base}/activation/activate`, | ||
| ], | ||
| graphqlURL: [`https://graphql.${base}/graphql`, `https://graphql.02.${base}/graphql`], | ||
| substrateURL: [`wss://tfchain.${base}/ws`, `wss://tfchain.02.${base}/ws`], | ||
| }; | ||
| const missingServicesURLS = getServicesWithoutURLs(currentURLs); | ||
|
|
||
| if (missingServicesURLS.length == 0) return; | ||
|
|
||
| const services = missingServicesURLS.reduce((acc, servicesName) => { | ||
| acc.push(prepareServices(servicesName, URLS[servicesName])); | ||
| return acc; | ||
| }, [] as Service[]); | ||
| const result = await new ServiceUrlManager({ | ||
| services: services, | ||
| silent: true, | ||
| }).getAvailableServicesStack(); | ||
| Object.assign(clientOptions, mapResult(result, missingServicesURLS)); | ||
| } |
There was a problem hiding this comment.
I think mutating object byRef might lead to unexpected behaviour specially in vue apps as it turns objects into proxy which rerender ui whenever it gets mutated
So I think we should avoid update objects byref
…into development_monitoring__stacks_gridclient
AhmedHanafy725
approved these changes
Aug 19, 2024
MohamedElmdary
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using monitoring package, we are getting the available url for services if it is not provided in clien options
Changes
add
setServiceURLsthat is updating client options with available services urls for only the services that do not associated with url in client options.this method is used in connect method and before
getDefaultUrlto insure that we have the available stack url for each serviceif it is not providedRelated Issues
sdk-ts: Support multiple stacks per network #3078Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist