Define the value argument in the TFChainError constructor #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Send the value of the prop that i want to define as an object that contain a 'value' attr - Set the 'enumerable: ture' to display the error args
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
zaelgohary
reviewed
Aug 13, 2024
zaelgohary
approved these changes
Aug 13, 2024
Mahmoud-Emad
changed the title
- dynamically defines the TFChainError key property instead of making a condition on each key in the 'TFChainError' contractor.
AhmedHanafy725
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the code changes suggested in this PR discussion, we initially observed that the
Generic Typehandled the failure correctly but theTFChainfailed. However, later on, @zaelgohary reported a change in the error pattern—neither KeyError nor TFChainError was being generated.After further debugging with @0oM4R, we identified the root cause: the value of the property was being sent as a
stringorundefined, while the method expects an object in the format{value: 'The actual value'}. Additionally, we discovered that using{enumerable: true}when defining properties helps ensure that the attributes are displayed correctly when errors are thrown.Changes
Related Issues
TFChainErroris not displayed when the client stuck during the execution #3304Checklist