Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support limiting publicip resources in k8s and caprover #3324

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Support limiting publicip resources in k8s and caprover #3324

merged 7 commits into from
Aug 22, 2024

Conversation

MohamedElmdary
Copy link
Member

Description

Support limiting publicip resources

Changes

  • Update yarn.lock as it was outdated
  • Add 'farmId' and 'publicIp' in selectedMachine type
  • use newly added props in k8s worker component
  • use newly added props in caprover worker component
  • Add get-farm and load-farm in selectionDetails to avoid loading farm more than once in a single deployment
  • Add support for checking publicIp resources from farm in auto node selector
  • Add support for checking publicIp resources from farm in manual node selector

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary MohamedElmdary self-assigned this Aug 20, 2024
Mahmoud-Emad
Mahmoud-Emad requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Rabe3

@MohamedElmdary MohamedElmdary merged commit 815d729 into development Aug 22, 2024
10 checks passed
@MohamedElmdary MohamedElmdary deleted the development_limit_publicip_resources branch August 22, 2024 11:17
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees

@MohamedElmdary MohamedElmdary

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MohamedElmdary @samaradel @Mahmoud-Emad @xmonader