Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binding to the correct variable to hide ssh dialogue #3410

Merged
merged 1 commit into from
Sep 19, 2024
Merged

binding to the correct variable to hide ssh dialogue #3410

merged 1 commit into from
Sep 19, 2024

Conversation

maayarosama
Copy link
Contributor

@maayarosama maayarosama commented Sep 17, 2024 •
edited
Loading

Description

binding to the correct variable to hide ssh dialouge in Domains
Screenshot from 2024-09-17 12-47-15

Changes

  • Binded the value to hideSSH instead of hide-ssh

Related Issues

Tested Scenarios

  • Navigated to Domains page, and There was no ssh dialouge

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@amiraabouhadid amiraabouhadid changed the title binding to the correct variable to hide ssh dialouge binding to the correct variable to hide ssh dialogue Sep 19, 2024
@maayarosama maayarosama merged commit 96eebe5 into development Sep 19, 2024
10 checks passed
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
@AhmedHanafy725 AhmedHanafy725 deleted the development_domain branch December 3, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maayarosama @samaradel @zaelgohary @xmonader