Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Applying KYC on farmers (#3763)" #3845

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jan 30, 2025

This reverts commit f0f91d9.

Description

revert farms KYC

This reverts commit f0f91d9.

Related Issues

#3840

Tested Scenarios

I was able to reach farms page with a new created account without being kyc verified

To consider

Preliminary Checks:

  • Preliminary Checks
    • Does it completely address the issue linked?
    • What about edge cases?
    • Does it meet the specified acceptance criteria?
    • Are there any unintended side effects?
    • Does the PR adhere to the team's coding conventions, style guides, and best practices?
    • Does it integrate well with existing features?
    • Does it impact the overall performance of the application?
    • Are there any bottlenecks or slowdowns?
    • Has it been optimized for efficiency?
    • Has it been adequately tested with unit, integration, and end-to-end tests?
    • Are there any known defects or issues?
    • Is the code well-documented?
    • Are changes to documentation reflected in the code?

UI Checks:

  • UI Checks
    • If a UI design is provided/ does it follow it?
    • Does every button work?
    • Is the data displayed logical? Is it what you expected?
    • Does every validation work?
    • Does this interface feel intuitive?
    • What about slow network? Offline?
    • What if the gridproxy/graphql/chain is failing?
    • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code Quality Checks
    • Code formatted/linted? Are there unused imports? .. etc
    • Is there redundant/repeated code?
    • Are there conditionals that are always true or always false?
    • Can we write this more concisely?
    • Can we reuse this code? If yes, where?
    • Will the changes be easy to maintain and update in the future?
    • Can this code become too complex to understand for other devs?
    • Can this code cause future integration problems?

Testing Checklist

  • Does it Meet the specified acceptance criteria.
  • Test if changes can affect any other functionality.
  • Tested with unit, integration, and end-to-end tests.
  • Tested the un-happy path and rollback scenarios.
  • Documentation updated to meet the latest changes.
  • Check automated tests working successfully with the changes.
  • Can be covered by automated tests.

General Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, i can see your farms page without being verified, but can we open up an issue to handle this kyc console err?

image

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 2, 2025

nice, i can see your farms page without being verified, but can we open up an issue to handle this kyc console err?

image

I'm afraid we can't prevent the network errors in console; we are already handling the network error in KYC client

if (!res.result.status)
throw new KycErrors.InvalidResponse("Failed to get status due to: Response does not contain status field");
return res.result.status;
} catch (error) {
if (error instanceof AxiosError && error.status === HttpStatusCode.NotFound) return KycStatus.unverified;
throw this.throwKycError(error, "Failed to get authentication status from KYC service.");
}

@0oM4R
Copy link
Contributor Author

0oM4R commented Feb 2, 2025

However, i opened an issue #3854 to investigate more about it

@0oM4R 0oM4R merged commit 5cdf91e into development Feb 2, 2025
10 checks passed
@0oM4R 0oM4R deleted the development_revert_farms_kyc branch February 2, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants