Use interfaces in gateway node selector #3860

0oM4R · 2025-02-03T16:24:22Z

Description

new zos-light nodes gateways supports only ipv4, ip6, myceluim so we need to make sure that the listed nodes are compatible with the selected interface; in applications, we are deploying the gateway over wireguard.

Changes

update the selecte node and domain name components to accept array of network features.
if the selected interface is ipv6 we have to set the hasIpv6 with true; without passing ipv6 in features
no need to pass ipv4 in any scenario as we already added it based on the gateway value
make selectedIPAddress as string as we always convert it to string everywhere
reorder the manage domain dialog
k8s :

vm:

interfaces.mov

Related Issues

#3858

Tested Scenarios

In applications that use gateways, we are passing wireguard to the features

in domains page it list the node 309 but you have to rent it first, you may see new shared nodes added

in manage domain dialog: if the vm contaisn only myceluim then the both node will be listed normally

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

Preliminary Checks
- Does it completely address the issue linked?
- What about edge cases?
- Does it meet the specified acceptance criteria?
- Are there any unintended side effects?
- Does the PR adhere to the team's coding conventions, style guides, and best practices?
- Does it integrate well with existing features?
- Does it impact the overall performance of the application?
- Are there any bottlenecks or slowdowns?
- Has it been optimized for efficiency?
- Has it been adequately tested with unit, integration, and end-to-end tests?
- Are there any known defects or issues?
- Is the code well-documented?
- Are changes to documentation reflected in the code?

UI Checks:

UI Checks
- If a UI design is provided/ does it follow it?
- Does every button work?
- Is the data displayed logical? Is it what you expected?
- Does every validation work?
- Does this interface feel intuitive?
- What about slow network? Offline?
- What if the gridproxy/graphql/chain is failing?
- What would a first time user have a hard time navigating here?

Code Quality Checks:

Code Quality Checks
- Code formatted/linted? Are there unused imports? .. etc
- Is there redundant/repeated code?
- Are there conditionals that are always true or always false?
- Can we write this more concisely?
- Can we reuse this code? If yes, where?
- Will the changes be easy to maintain and update in the future?
- Can this code become too complex to understand for other devs?
- Can this code cause future integration problems?

Testing Checklist

Does it Meet the specified acceptance criteria.
Test if changes can affect any other functionality.
Tested with unit, integration, and end-to-end tests.
Tested the un-happy path and rollback scenarios.
Documentation updated to meet the latest changes.
Check automated tests working successfully with the changes.
Can be covered by automated tests.

General Checklist

… maybe got enahnced later

…into development_gateway_interfaces

- refactor: change the type of selectedIPAddress as it always got converted to string - pass the selected interface type as feature to the domainName component

maayarosama · 2025-02-16T11:45:46Z

packages/playground/src/components/manage_gateway_dialog.vue

@@ -263,6 +268,21 @@ export default {
    const availableK8SNodesNames = availableK8SNodes.map(node => node.name);
    const selectedK8SNodeName = ref(availableK8SNodesNames[0]);
    const selectedNode = ref();
+    const interfaceFeature = computed<NetworkFeatures[]>(() => {
+      const net = networks.value.find(net => net.value == selectedIPAddress.value);
+      switch (net?.title) {


please add public ipv4 case

nvm, ignore the comment

amiraabouhadid

was able to deploy a domain on mycelium and on wireguard. Filters work seem to work. Couldn't try de02.dev.grid.tf as node 314 was rented. Nor gent02 as node 11 is excluded

amiraabouhadid

tried with de2, works

0oM4R added 5 commits February 3, 2025 15:18

feature: support passing interfaces as features on gateway nodes query

4d7d0d8

WIP: bind features to domain name features

b7a4cb1

chore(GatewayInterfaces): remove other interfaces keep only wireguard

323441c

chore(GatewayInterfaces): cleanup

deee662

chore(GatewayInterfaces): Fix gateway on ip, this is a workaround and…

7f21f9c

… maybe got enahnced later

0oM4R changed the title ~~Development gateway interfaces~~ Use interfaces in gateway node selector Feb 5, 2025

0oM4R added 2 commits February 5, 2025 11:53

Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-ts …

6ff03ff

…into development_gateway_interfaces

chore(GatewayInterfaces): set the has_ipv6 to undefined instead of false

cd18b18

0oM4R mentioned this pull request Feb 10, 2025

🐞 [Bug]: unclear error while deploying on node 313 and 314 domains #3874

Closed

1 task

0oM4R added 4 commits February 11, 2025 13:17

Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-ts …

3908771

…into development_gateway_interfaces

Style(CustomDomain): make the tooltip aligned center

420b322

Style(DomainDialog): reorder fiedls

36fd7f8

Feature(GatewayDialog):

592f028

- refactor: change the type of selectedIPAddress as it always got converted to string - pass the selected interface type as feature to the domainName component

0oM4R marked this pull request as ready for review February 16, 2025 11:23

0oM4R requested review from AhmedHanafy725, zaelgohary, maayarosama, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar and samaradel as code owners February 16, 2025 11:23

maayarosama reviewed Feb 16, 2025

View reviewed changes

maayarosama approved these changes Feb 16, 2025

View reviewed changes

amiraabouhadid reviewed Feb 17, 2025

View reviewed changes

amiraabouhadid approved these changes Feb 17, 2025

View reviewed changes

AhmedHanafy725 requested a review from ramezsaeed February 17, 2025 13:14

ramezsaeed approved these changes Feb 18, 2025

View reviewed changes

0oM4R merged commit 4dd5f0f into development Feb 18, 2025
10 checks passed

ramezsaeed mentioned this pull request Feb 19, 2025

QA progress threefoldtech/home#1575

Open

AhmedHanafy725 deleted the development_gateway_interfaces branch February 19, 2025 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use interfaces in gateway node selector #3860

Use interfaces in gateway node selector #3860

0oM4R commented Feb 3, 2025 •

edited

Loading

maayarosama Feb 16, 2025

maayarosama Feb 16, 2025

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid left a comment

Use interfaces in gateway node selector #3860

Use interfaces in gateway node selector #3860

Conversation

0oM4R commented Feb 3, 2025 • edited Loading

Description

Changes

Related Issues

Tested Scenarios

Documentation PR

To consider

Preliminary Checks:

UI Checks:

Code Quality Checks:

Testing Checklist

General Checklist

maayarosama Feb 16, 2025

Choose a reason for hiding this comment

maayarosama Feb 16, 2025

Choose a reason for hiding this comment

amiraabouhadid left a comment • edited Loading

Choose a reason for hiding this comment

amiraabouhadid left a comment

Choose a reason for hiding this comment

0oM4R commented Feb 3, 2025 •

edited

Loading

amiraabouhadid left a comment •

edited

Loading