Add MIDI Program Change, SysEx, NRPN, PitchBend and AfterTouch Output #1244

nkymut · 2025-01-18T07:05:54Z

This update adds support for sending MIDI Program Change and System Exclusive (SysEx) messages for @strudel/midi package. It builds upon the changes made in #1212; however, MIDI mapping and Hi-res CC have not been tested yet.

Examples:

Program Change:

// [obsolete]note("c a f e").pc("<0 1 2>").midichan(1).midi()
$: note("c a f e").progNum("<0 1 2>").midichan(1).midi()
$: "10 20 30".progNum().midichan(1).midi()

// midi/gm.mjs provides mapping of gm intrrument names and pg numbers. 
// [obsolete] note("c a f e").pc(gm['marimba']).midichan(2).midi()
note("c a f e").progNum(gm['marimba']).midichan(2).midi()
//use midicmd
$: note("c a f e").midicmd("progNum:10").midichan(1).midi()
$: "progNum:20 progNum:30".midicmd().midichan(1).midi()

SysEx Messages:

// Send a simple SysEx message
let id = 0x43; //Yamaha ID for Gakken(Yamaha) NSX-39
let data = "0x79:0x09:0x11:0x0A:0x00:0x00"; // Set NSX-39 voice to say "Aa"

$: note("c d e f e d c").sysex([id,data]).midi();
$: note("c d e f e d c").sysexid(id).sysexdata(data).midi();

//ID can be an array of numbers
//let id = "0x00:0x20:0x32"; //Behringer

midibend && miditouch

midibend sets MIDI pitch bend (-1 - 1)
miditouch sets MIDI key after touch (0-1)

$: note("c d e f e d c").midibend(sine.slow(4).range(-0.4,0.4)).midi();
$: note("c d e f e d c").miditouch(sine.slow(4).range(0,1)).midi();

cc,progNum, sysex for `midicmd` Messages:

cc - sends MIDI control change messages.
progNum - sends MIDI program change messages.
sysex - sends MIDI system exclusive messages.

stack(
  // "cc:ccn:ccv"
  midicmd("cc:74:1").midi('IAC Driver'),
  // "progNum:progNum"
  midicmd("progNum:1").midi('IAC Driver'),
  // "sysex:[sysexid]:[sysexdata]"
  midicmd("sysex:[0x43]:[0x79:0x09:0x11:0x0A:0x00:0x00]").midi('IAC Driver')
)

Test & ToDo

GAKKEN(YAMAHA) NSX-39
update pc to progNum
add progNum support to midicmd
add sysex support to midicmd
MIDI mappings External mappings for MIDI instruments #1212 → midimaps #1274

This commit adds a second argument to the midi() command: mapping. This argument should be an object containing a key-value map of MIDI controls used by an external synthesizer. If any control is used that matches the mapping, a CC message is sent.

split sysex message into sysexid and sysexdata sysexid is a device identification number or array sysexdata is an array of data to be sent to the device

- add example sysex data for setting NSX-39(Pocket Miku) voice data.

…d-program-change

felixroos · 2025-01-18T22:14:48Z

great stuff! would it make sense to add this to the existing midicmd ( #710 ) instead of the new pc function?

felixroos · 2025-01-18T22:33:37Z

wow also nice work on the docs

nkymut · 2025-01-19T13:53:41Z

Thank you for bringing this to my attention (#710). I overlooked the existing midicmd control completely.
I should have also referenced Tidal's MIDI control conventions,
as I agree that the pc function (for program change) could be more descriptive.

Superdirt uses a 'midicmd' control to specify the different midi commands.
https://tidalcycles.org/docs/configuration/MIDIOSC/midi/#synchronising-midi-clock-via-tidal

This mirrors the supercollider midi api
https://doc.sccode.org/Tutorials/A-Practical-Guide/PG_08_Event_Types_and_Parameters.html#MIDI%20output

nkymut · 2025-01-19T15:52:05Z

Regarding sysex (System Exclusive) messages,
I'm struggling with how to pass multiple pattern arguments (esp involving lists) to functions.

While ideally I'd want to structure it as:

sysex(id, data)

Currently, I've split it into:

sysexid(id).sysexdata(data)

This split approach largely follows webmidijs's sendSysex method specification,
which handles ID and data as separate parameters.
https://webmidijs.org/api/classes/Output#sendSysex

sendSysex([id],[data],[option])

If we adopt midicmd, it would be

midicmd("sysex:id:data")

here are some relevant topic on discord channel.
SysEx and lists
https://discordapp.com/channels/779427371270275082/1191429292744245250/1329202181055709226
Concatenate strings as a pattern
https://discordapp.com/channels/779427371270275082/1191429292744245250/1304375383268921397

Or

- addresses tidalcycles#789 tidalcycles#710

- MiniRepl for input-output.mdx - addresses tidalcycles#789 tidalcycles#710

- add progNum keyword handler - update midicmd handler to handle 'progNum' case

- sysex(id, data) and both arguments are patternable

nkymut · 2025-01-23T00:51:02Z

I have managed to get sysex(id, data) working while keeping it chainable and the arguments are patternable Yay!
BTW, the idea that everything in Strudel/Tidal is a pattern is genuinely fascinating!

Here I have added a sysex method in controls.mjs using register from '@strudel/core' and pass args into 'sysexid' and 'sysexdata' controls to process furthur making the method to return a Pattern,.

export const sysex = register('sysex', (args, pat) => {
  if (!Array.isArray(args)) {
    throw new Error('sysex expects an array of [id, data]');
  }
  const [id, data] = args;
  return pat.sysexid(id).sysexdata(data); //return a chain of controls (which returns a Pattern)
});

felixroos · 2025-01-24T09:25:17Z

thanks! looking forward to testing this. i hope this can be part of the next release (happening soonish)

felixroos · 2025-01-24T09:32:03Z

so i assume we have to merge #1212 first, right?

nkymut · 2025-01-24T11:18:33Z

I tried adding API references, but it’s causing errors in the test code. I’ll fix it tomorrow morning by adding some dummy code for testing MIDI in and out.

- add mock 'midin' and 'sysex' - typo in sysex example

felixroos · 2025-02-07T10:08:54Z

#1274 is now merged, so this PR could now be updated to use the new API

…d-program-change

- Move MIDI API logic into separate functions following tidalcycles#1274 (sendCC, sendProgramChange, sendPitchBend, etc.)

felixroos · 2025-03-08T12:59:24Z

@nkymut is this one ready for a review?

nkymut · 2025-03-08T13:11:59Z

Yes, I've been regularly using the setup with multiple midi devices (two NSX-39 units, an OP-LAB, a NUX TapeEcho, and a Behringer RD-6), and haven't encountered any issues so far. It's ready for a review. Thank you!

felixroos · 2025-03-08T21:00:37Z

packages/midi/midi.mjs

+
+  //TODO: MIDI mapping related
+  if (typeof output === 'object') {
+    const { port, controller = false, ...remainingProps } = output;


isn't that obsolete now?

yes, its obsolete. As #1274 merged and we can use midimaps instead.
not sure if its necessary to keep it for backward compatibility? @Bubobubobubobubo

afaik "output" being an object was never in main

felixroos · 2025-03-08T21:01:08Z

packages/midi/midi.mjs

 function mapCC(mapping, value) {
+  console.log('mapping', mapping);


is this log useful here, or an artifact of debugging?

felixroos · 2025-03-08T21:02:11Z

packages/midi/midi.mjs

@@ -254,22 +342,57 @@ Pattern.prototype.midi = function (output) {
    velocity = gain * velocity;
    // if midimap is set, send a cc messages from defined controls
    if (midicontrolMap.has(midimap)) {
+      console.log('midimap', midimap);


do we need that log?

felixroos · 2025-03-08T21:04:15Z

packages/midi/midi.mjs

      const ccs = mapCC(midicontrolMap.get(midimap), hap.value);
      ccs.forEach(({ ccn, ccv }) => sendCC(ccn, ccv, device, midichan, timeOffsetString));
    }

    // note off messages will often a few ms arrive late, try to prevent glitching by subtracting from the duration length
    const duration = (hap.duration.valueOf() / cps) * 1000 - 10;
-    if (note != null) {
+    if (note != null && !isController) {


do we need the isController flag? iirc it was part of the old midimapping format? how would it be set with the new format?

felixroos · 2025-03-08T21:05:48Z

i've read the code and added some comments / questions. all in all this looks good :)

…d-program-change

…into add-program-change

Bubobubobubobubo and others added 11 commits November 9, 2024 01:41

Getting rid of second argument

23a4bf6

Add high-resolution CC option to midi

bd69ffb

Add program change(pc) and sysex to midi

859f153

midi mapping to handle program change and sysex

c242f5f

register pc and sysex as control keywords

155ef9e

add documentation for pc and sysex

e085819

Get sysex working

13a4512

split sysex message into sysexid and sysexdata sysexid is a device identification number or array sysexdata is an array of data to be sent to the device

Add device specific setting folder 1

3325a8d

- add example sysex data for setting NSX-39(Pocket Miku) voice data.

Merge branch 'main' of https://github.com/tidalcycles/strudel into ad…

bfb4eee

…d-program-change

prettier!

a880378

nkymut force-pushed the add-program-change branch from 37f826f to a880378 Compare January 18, 2025 18:33

nkymut added 5 commits January 20, 2025 01:11

add midicmd documentation

268c66c

- addresses tidalcycles#789 tidalcycles#710

add midicmd documentation 2

1349ecb

- MiniRepl for input-output.mdx - addresses tidalcycles#789 tidalcycles#710

adjust midicmd heading level

f95eada

update ProgramChange from pc to progNum

a4792e2

- add progNum keyword handler - update midicmd handler to handle 'progNum' case

Add 'sysex' control

57c48f0

- sysex(id, data) and both arguments are patternable

Add cc to midicmd, add API Reference for midi related controls

d06a75a

felixroos added the v1.2 label Jan 24, 2025

nkymut added 3 commits January 25, 2025 01:12

fix test error

393d17a

- add mock 'midin' and 'sysex' - typo in sysex example

add midibend, miditouch

b8b999e

update documents

e19d059

nkymut added 3 commits January 25, 2025 03:27

fix midibend and miditouch

3189b36

Prettier!

3ffe395

add testsnapshot

c5d7f95

Bubobubobubobubo mentioned this pull request Feb 2, 2025

External mappings for MIDI instruments #1212

Closed

3 tasks

remove experimental code

4636d82

Bubobubobubobubo mentioned this pull request Feb 3, 2025

midimaps #1274

Merged

4 tasks

nkymut added 7 commits February 4, 2025 02:49

codeformat

ed7dc4e

Add midicmd JSdoc

52d1443

add sysex handler to midicmd

20dcae6

update 'midicmd' in README.md

9b279ff

edit README.md

54c5454

'miditouch' change sendKeyAfterTouch to sendChannelAfterTouch

5ff1d35

fix sendChannelAfterTouch -> sendChannelAftertouch

451cdcc

nkymut added 4 commits February 9, 2025 10:53

Merge branch 'main' of https://github.com/tidalcycles/strudel into ad…

919c285

…d-program-change

refactor(midi): extract MIDI message handlers into dedicated functions

f802f18

- Move MIDI API logic into separate functions following tidalcycles#1274 (sendCC, sendProgramChange, sendPitchBend, etc.)

remove midimap JSDoc

b98ebc6

codeformat

43523b7

nkymut mentioned this pull request Feb 9, 2025

Midimap+ #1284

Open

felixroos reviewed Mar 8, 2025

View reviewed changes

felixroos and others added 4 commits March 8, 2025 22:08

Merge branch 'main' into add-program-change

09dd374

Merge branch 'main' of https://github.com/tidalcycles/strudel into ad…

a18d485

…d-program-change

Merge branch 'add-program-change' of https://github.com/nkymut/strudel …

756a650

…into add-program-change

remove debugging artifacts

3c2692b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MIDI Program Change, SysEx, NRPN, PitchBend and AfterTouch Output #1244

Add MIDI Program Change, SysEx, NRPN, PitchBend and AfterTouch Output #1244

nkymut commented Jan 18, 2025 •

edited

Loading

felixroos commented Jan 18, 2025

felixroos commented Jan 18, 2025

nkymut commented Jan 19, 2025

nkymut commented Jan 19, 2025 •

edited

Loading

nkymut commented Jan 23, 2025 •

edited

Loading

felixroos commented Jan 24, 2025

felixroos commented Jan 24, 2025

nkymut commented Jan 24, 2025

felixroos commented Feb 7, 2025

felixroos commented Mar 8, 2025

nkymut commented Mar 8, 2025

felixroos Mar 8, 2025

nkymut Mar 8, 2025

felixroos Mar 9, 2025

felixroos Mar 8, 2025

felixroos Mar 8, 2025

felixroos Mar 8, 2025

felixroos commented Mar 8, 2025

		function mapCC(mapping, value) {
		console.log('mapping', mapping);

Add MIDI Program Change, SysEx, NRPN, PitchBend and AfterTouch Output #1244

Are you sure you want to change the base?

Add MIDI Program Change, SysEx, NRPN, PitchBend and AfterTouch Output #1244

Conversation

nkymut commented Jan 18, 2025 • edited Loading

Examples:

Program Change:

SysEx Messages:

midibend && miditouch

cc,progNum, sysex for midicmd Messages:

Test & ToDo

felixroos commented Jan 18, 2025

felixroos commented Jan 18, 2025

nkymut commented Jan 19, 2025

nkymut commented Jan 19, 2025 • edited Loading

nkymut commented Jan 23, 2025 • edited Loading

felixroos commented Jan 24, 2025

felixroos commented Jan 24, 2025

nkymut commented Jan 24, 2025

felixroos commented Feb 7, 2025

felixroos commented Mar 8, 2025

nkymut commented Mar 8, 2025

felixroos Mar 8, 2025

Choose a reason for hiding this comment

nkymut Mar 8, 2025

Choose a reason for hiding this comment

felixroos Mar 9, 2025

Choose a reason for hiding this comment

felixroos Mar 8, 2025

Choose a reason for hiding this comment

felixroos Mar 8, 2025

Choose a reason for hiding this comment

felixroos Mar 8, 2025

Choose a reason for hiding this comment

felixroos commented Mar 8, 2025

nkymut commented Jan 18, 2025 •

edited

Loading

cc,progNum, sysex for `midicmd` Messages:

nkymut commented Jan 19, 2025 •

edited

Loading

nkymut commented Jan 23, 2025 •

edited

Loading