Exclude cached routes with randomly generated names #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run
php artisan route:cache
, Laravel assigns unnamed routes a unique, randomly generated name that looks something likegenerated::ZRopaJJwzA27wRLa
.Ziggy should ignore these routes because they don't actually have explicit names assigned by the developer, so including them in the output will increase its size considerably and could expose information that should not be visible client-side.
To that end, this PR just filters out any route whose name starts with
generated::
.I tried to actually cache the routes in a test, but Testbench doesn't support this out of the box and I kept getting very weird Opis/Closure errors. Here's what I was trying, more or less: