raft: reduce memory allocation when reset #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this depends on #119 ? |
Hoverbear
reviewed
Oct 5, 2018
Hoverbear
reviewed
Oct 5, 2018
Hoverbear
previously approved these changes
Nov 1, 2018
|
Merged and resolved conflicts for you :) |
|
@overvenus PTAL |
|
PTAL @hicqu |
|
LGTM. 👍 |
hicqu
previously approved these changes
Nov 8, 2018
|
I'll handle it! Thanks. :) |
siddontang
approved these changes
Nov 8, 2018
|
@Hoverbear please approves it |
bors bot
added a commit
that referenced
this pull request
Nov 8, 2018
130: raft: reduce memory allocation when reset r=Hoverbear a=BusyJay
Create a new progress will allocate a vec. So this pr adds a reset function to avoid the allocation. Little performance enhancement is detected:
```
Raft::campaign (7, 3, CampaignElection)
time: [2.8076 us 2.8291 us 2.8565 us]
change: [-4.6982% -4.2007% -3.6530%] (p = 0.00 < 0.05)
Performance has improved.
```
Co-authored-by: Jay Lee <[email protected]>
Co-authored-by: Hoverbear <[email protected]>
Co-authored-by: qupeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new progress will allocate a vec. So this pr adds a reset function to avoid the allocation. Little performance enhancement is detected: