Only allow valid Id s to be constructed
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use newtypes for the enum variants so they cannot be constructed anymore. Implement the `From` trait for the variants to access the id value as integer.
timokroeger
added a commit
to timokroeger/pcan-basic-rs
that referenced
this pull request
Nov 15, 2020
timokroeger
added a commit
to timokroeger/stm32f1xx-hal
that referenced
this pull request
Nov 15, 2020
|
Note to self: Update README.md implementation links before merging this PR. |
timokroeger
added a commit
to timokroeger/stm32f1xx-hal
that referenced
this pull request
Nov 17, 2020
timokroeger
added a commit
to timokroeger/pcan-basic-rs
that referenced
this pull request
Nov 17, 2020
timokroeger
added a commit
to timokroeger/embedded-hal
that referenced
this pull request
Nov 17, 2020
Use newtypes for the enum variants so they cannot be constructed anymore. Implement the `From` trait for the variants to access the id value as integer. timokroeger/embedded-can#7
timokroeger
added a commit
to timokroeger/embedded-hal
that referenced
this pull request
Nov 18, 2020
Use newtypes for the enum variants so they cannot be constructed anymore. Implement the `From` trait for the variants to access the id value as integer. timokroeger/embedded-can#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use newtypes for the enum variants so they cannot be constructed
anymore. Implement the
Fromtrait for the variants to access the idvalue as integer.