Remove kernel parameter ip=dhcp in auto.ipxe: #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a machine had multiple interfaces that weren't all plugged in, this would cause significant delay in booting into Hook. If necessary, this value can be added back in via the `-extra-kernel-args` cli flag. Signed-off-by: Jacob Weinstock <[email protected]>
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #339 +/- ##
===================================
Coverage 30% 30%
===================================
Files 6 6
Lines 426 426
===================================
Hits 129 129
Misses 288 288
Partials 9 9 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a machine had multiple interfaces that weren't all plugged in, this would cause significant delay in booting into Hook.
If necessary, this value can be added back in via the
-extra-kernel-argscli flag.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: