Add retries to auto.ipxe kernel/initrd downloads: #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
previously approved these changes
Apr 23, 2024
|
Based on a conversation in today's community meeting with @chrisdoherty4, I'm going to add configurability to the number of retries. |
jacobweinstock
force-pushed
the
retry-ipxe-script
branch
from
8b6dd02 to
fe97306
Compare
This will help overcome transient network issues. Signed-off-by: Jacob Weinstock <[email protected]>
This allows for transient network issues to not cause the iPXE script to fail downloading kernel and initramfs. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
retry-ipxe-script
branch
from
fe97306 to
cf4aad5
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
This makes the retries count work in iPXE. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
===================================
- Coverage 69% 69% -1%
===================================
Files 16 16
Lines 1386 1389 +3
===================================
+ Hits 958 960 +2
- Misses 401 402 +1
Partials 27 27 ☔ View full report in Codecov by Sentry. |
chrisdoherty4
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will help overcome transient network issues.
Why is this needed
Fixes: #333
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: