Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Raspberry PI mac prefixes: #458

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

jacobweinstock
Copy link
Member

Description

There are new mac prefixes for Raspberry PIs. Use mac address to determine Architecture for Raspberry PI's. This is needed because in my testing Raspberry PI 5 identifies itself in DHCP option 93 as an INTEL_X86PC.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (8ec6119) to head (9168e51).

Current head 9168e51 differs from pull request most recent head 08200eb

Please upload reports for the commit 08200eb to get more accurate results.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #458   +/-   ##
===================================
  Coverage    69%    69%           
===================================
  Files        16     16           
  Lines      1392   1402   +10     
===================================
+ Hits        962    972   +10     
  Misses      403    403           
  Partials     27     27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock jacobweinstock force-pushed the rpi branch 2 times, most recently from fd337be to 9168e51 Compare May 28, 2024 15:07
There are new mac prefixes for Raspberry PIs.
Use mac address to determine Architecture for
Raspberry PI's. This is needed because in my
testing Raspberry PI 5 identifies itself in
DHCP option 93 as an INTEL_X86PC.

Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit b2a27c5 into tinkerbell:main May 30, 2024
3 checks passed
@jacobweinstock jacobweinstock deleted the rpi branch May 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant