Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chat) 타입 정리 #3589

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

(Chat) 타입 정리 #3589

wants to merge 15 commits into from

Conversation

dia-triple
Copy link
Contributor

@dia-triple dia-triple commented Mar 11, 2025

PR 설명

  • chat/types/index에 정의된 타입들을 도메인(user, message, room...)에 따라 분리합니다.
  • UserType, RoomType 등을 확장해서 사용할 수 있도록 합니다.
    • ex. tna-partners-web에서는 UserType에 INTERPARK_USER 가 추가되고, RoomType에 INTERPARK_TNA_PRODUCTINTERPARK_TNA_BOOKING이 추가됩니다.
  • triple-chat/nol-chat API response와 컴포넌트 내에서 사용하는 interface를 분리합니다.
    • chat 컴포넌트 내에서 사용되는 UserInterface와 API 응답모델인 ChatUserInterface 분리
    • triple-chat 서버 응답으로 받는 RoomInterface, nol-chat 서버 응답으로 받는 ChatRoomDetailInterface, 컴포넌트 내에서 사용하는 ChatRoomInterface 분리

변경 내역

체크리스트

스크린샷 & URL

@dia-triple dia-triple self-assigned this Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 14.02%. Comparing base (d0336f7) to head (3ead745).

Files with missing lines Patch % Lines
packages/tds-widget/src/chat/types/room.ts 0.00% 3 Missing ⚠️
packages/tds-widget/src/chat/types/message.ts 0.00% 1 Missing ⚠️
packages/tds-widget/src/chat/types/user.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
- Coverage   14.02%   14.02%   -0.01%     
==========================================
  Files         749      751       +2     
  Lines       10579    10582       +3     
  Branches     3649     3649              
==========================================
  Hits         1484     1484              
- Misses       8665     8668       +3     
  Partials      430      430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.111 has been published!

@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.115 has been published!

@dia-triple dia-triple force-pushed the feat/extend-chat-types branch from e999080 to e620717 Compare March 12, 2025 00:48
@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.118 has been published!

@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.119 has been published!

@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.121 has been published!

@dia-triple dia-triple force-pushed the feat/extend-chat-types branch from 6a0eacf to 13f5eda Compare March 14, 2025 02:25
@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.122 has been published!

@dia-triple
Copy link
Contributor Author

release-canary

Copy link

v14.0.12-pr-3589.124 has been published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant