Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a merging audo and video command #3718

Closed
wants to merge 3 commits into from
Closed

Added a merging audo and video command #3718

wants to merge 3 commits into from

Conversation

therayvoice
Copy link
Contributor

I need this command again and again but keep forgetting.

  • The page has 8 or fewer examples.
    Not really, the page is a bit long, however people using this tool don't really care as long as it's well organized and to the point.
  • [ x ] The PR title conforms to the recommended templates.
  • [ x ] The page follows the content guidelines.

I need this command again and again but keep forgetting.
@claassistantio
Copy link

claassistantio commented Dec 31, 2019

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build
for this PR failed with the following error(s):

Error: Parse error on line 42:
...imental output.mp4`
----------------------^
Expecting 'NEWLINE', 'BACKTICK', got '1'
pages/common/ffmpeg.md:38: TLDR005 Example descriptions should end in a colon
pages/common/ffmpeg.md:39: TLDR103 Command example is missing its closing backtick
pages/common/ffmpeg.md:41: TLDR002 A single space should precede a sentence
pages/common/ffmpeg.md:41: TLDR003 Descriptions should start with a capital letter
pages/common/ffmpeg.md:41: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ray6464 , there are already enough examples, we shouldn't break the guideline .

Copy link
Contributor

@zlatanvasovic zlatanvasovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still 1 example too much.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the edit @ray6464! I've left a comment below for you to review.

In addition, it looks like we've got too many examples on this page. Which one would you suggest is the least useful?

Finally, it looks like you haven't yet signed the CLA. We need you to sign this in order to be able to merge your PR. Note that the email address you've committed with has to be present in your GitHub account settings.

@ivanhercaz ivanhercaz added the page edit Changes to an existing page(s). label Jan 2, 2020
Works both ways, mine requires a little brain, yours requires a little more brain. lol!

Co-Authored-By: Starbeamrainbowlabs <[email protected]>
@therayvoice
Copy link
Contributor Author

therayvoice commented Jan 5, 2020

Hey, thanks for the edit @ray6464! I've left a comment below for you to review.

In addition, it looks like we've got too many examples on this page. Which one would you suggest is the least useful?

Finally, it looks like you haven't yet signed the CLA. We need you to sign this in order to be able to merge your PR. Note that the email address you've committed with has to be present in your GitHub account settings.

I don't know anything about video editing, however the "Convert MP4 video to VP9 codec" seems useless for me for the most part, it has 4 "unknowns" in it which suggests that if the user really using ffmpeg for that kind of stuff they should just read man pages instead of tldr, I mean 4 variables? how in the world is that tldr.

I also suggest that tldr should keep both smaller and longer versions of files that works when tldr is used with a "-L" flag. I mean the idea behind tldr is not keeping the docs small but the examples small and simple right? Keeping the docs as small as 8 examples is a huge setback without a clear philosophy of what example goes in and what goes out.

TL;DR: My commit in, lengthy commits out!

@sbrl
Copy link
Member

sbrl commented Jan 6, 2020

My knowledge of video editing is more limited than I'd like it to be, but VP9 is the latest WebM codec (which is great for embedding videos in web pages, since it tends to generate smaller files), so I think that example is useful. However, I certainly agree that it can be simplified. For example if a specific value must be zero, then there's no need to mention it in the description.

Regarding shorter and longer versions of pages, that's probably best suggested in a separate issue. Perhaps you could open one?

@zlatanvasovic
Copy link
Contributor

I also agree this example is useful. Perhaps we could change maximum number of examples to 10.

@therayvoice
Copy link
Contributor Author

My knowledge of video editing is more limited than I'd like it to be, but VP9 is the latest WebM codec (which is great for embedding videos in web pages, since it tends to generate smaller files), so I think that example is useful. However, I certainly agree that it can be simplified. For example if a specific value must be zero, then there's no need to mention it in the description.

Regarding shorter and longer versions of pages, that's probably best suggested in a separate issue. Perhaps you could open one?

How about this, if the example is really useful it's allowed through the 8-example limit, than later if we have a over-flow problem we can break the overflowing pages into small pages with an 8-limit and larger pages.

Also keep in mind that the 8-limit is will eventually kill this tool, it's very limiting; Instead of 8-limits, let the 8-limit be a rule of a loose thumb and lets be very strict about what goes in and what comes out. How about that?

@zlatanvasovic
Copy link
Contributor

I would definitely keep the limit, @ray6464. Our pages are supposed to be short and concise. On the other side, I'd prefer 10 examples instead of arbitrarily chosen 8.

@therayvoice therayvoice requested review from sbrl and einverne January 8, 2020 13:58
@therayvoice
Copy link
Contributor Author

I would definitely keep the limit, @ray6464. Our pages are supposed to be short and concise. On the other side, I'd prefer 10 examples instead of arbitrarily chosen 8.

Works for me!

@sbrl
Copy link
Member

sbrl commented Jan 10, 2020

Changing the limit on the number of examples is not a small change - it should be discussed in a separate issue. I'm sure there was a reason for the existing limit - I'm just not sure what it is.

@zlatanvasovic
Copy link
Contributor

It definitely does. Do you have some formed text for the matter, so you can open the issue yourself?

@sbrl
Copy link
Member

sbrl commented Jan 10, 2020

Define formed text

@zlatanvasovic
Copy link
Contributor

That means: do you have some worthy thoughts or comments about it to write down in the (supposed) issue's description?

@owenvoke
Copy link
Member

owenvoke commented Jan 12, 2020

@sbrl / @zdroid, #2799

@sbrl
Copy link
Member

sbrl commented Jan 13, 2020

Ah, thanks @pxgamer! I did have a feeling that we discussed it before.

@therayvoice therayvoice deleted the patch-1 branch January 16, 2020 15:38
@zlatanvasovic
Copy link
Contributor

🙍‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants