-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a merging audo and video command #3718
Conversation
I need this command again and again but keep forgetting.
The build
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still 1 example too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the edit @ray6464! I've left a comment below for you to review.
In addition, it looks like we've got too many examples on this page. Which one would you suggest is the least useful?
Finally, it looks like you haven't yet signed the CLA. We need you to sign this in order to be able to merge your PR. Note that the email address you've committed with has to be present in your GitHub account settings.
Works both ways, mine requires a little brain, yours requires a little more brain. lol! Co-Authored-By: Starbeamrainbowlabs <[email protected]>
I don't know anything about video editing, however the "Convert MP4 video to VP9 codec" seems useless for me for the most part, it has 4 "unknowns" in it which suggests that if the user really using ffmpeg for that kind of stuff they should just read man pages instead of tldr, I mean 4 variables? how in the world is that tldr. I also suggest that tldr should keep both smaller and longer versions of files that works when tldr is used with a "-L" flag. I mean the idea behind tldr is not keeping the docs small but the examples small and simple right? Keeping the docs as small as 8 examples is a huge setback without a clear philosophy of what example goes in and what goes out. TL;DR: My commit in, lengthy commits out! |
My knowledge of video editing is more limited than I'd like it to be, but VP9 is the latest WebM codec (which is great for embedding videos in web pages, since it tends to generate smaller files), so I think that example is useful. However, I certainly agree that it can be simplified. For example if a specific value must be zero, then there's no need to mention it in the description. Regarding shorter and longer versions of pages, that's probably best suggested in a separate issue. Perhaps you could open one? |
I also agree this example is useful. Perhaps we could change maximum number of examples to 10. |
How about this, if the example is really useful it's allowed through the 8-example limit, than later if we have a over-flow problem we can break the overflowing pages into small pages with an 8-limit and larger pages. Also keep in mind that the 8-limit is will eventually kill this tool, it's very limiting; Instead of 8-limits, let the 8-limit be a rule of a loose thumb and lets be very strict about what goes in and what comes out. How about that? |
I would definitely keep the limit, @ray6464. Our pages are supposed to be short and concise. On the other side, I'd prefer 10 examples instead of arbitrarily chosen 8. |
Works for me! |
Changing the limit on the number of examples is not a small change - it should be discussed in a separate issue. I'm sure there was a reason for the existing limit - I'm just not sure what it is. |
It definitely does. Do you have some formed text for the matter, so you can open the issue yourself? |
Define |
That means: do you have some worthy thoughts or comments about it to write down in the (supposed) issue's description? |
Ah, thanks @pxgamer! I did have a feeling that we discussed it before. |
🙍♀️ |
I need this command again and again but keep forgetting.
Not really, the page is a bit long, however people using this tool don't really care as long as it's well organized and to the point.