Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osx/g*: add page #9252

Merged
merged 142 commits into from
Nov 25, 2022
Merged

osx/g*: add page #9252

merged 142 commits into from
Nov 25, 2022

Conversation

pixelcmtd
Copy link
Member

@pixelcmtd pixelcmtd commented Oct 22, 2022 •
edited
Loading

I decided to leave gdu out, because it's a name collision.

@pixelcmtd pixelcmtd added the review needed Prioritized PRs marked for reviews from maintainers. label Oct 28, 2022
@pixelcmtd pixelcmtd requested a review from kbdharun October 28, 2022 14:03
kbdharun
kbdharun approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

We just need to implement this flag in our npm client I guess.

navarroaxel
navarroaxel reviewed Oct 28, 2022
View reviewed changes
pages/osx/g[.md Outdated

- View documentation for the original command:

`tldr --platform linux [`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the --platform is not required in the spec, we should use -p like the tldr page has

Suggested change
`tldr --platform linux [`
`tldr -p linux [`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but who came up with that idea?! For a project that emphasizes long and readable arguments as much as tldr does, that is one of the dumbest things I've heard in a long time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't here in that time. @waldyrious wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I am questioning myself 😄 , Should we update all the alias pages too then?

Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but who came up with that idea?! For a project that emphasizes long and readable arguments as much as tldr does, that is one of the dumbest things I've heard in a long time.

Until project doesn't have formal rule in style guide about using long options it's up to you (here) whether to use them or not and nobody can force you to use them even there are reasons why.

@kbdharun kbdharun added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 31, 2022
@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Nov 24, 2022
EmilyGraceSeville7cf
EmilyGraceSeville7cf approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No mandatory changes found, approved.
  • Thanks for a contribution! ❤️

@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Nov 25, 2022
@pixelcmtd pixelcmtd removed the review needed Prioritized PRs marked for reviews from maintainers. label Nov 25, 2022
@pixelcmtd pixelcmtd merged commit df6ed27 into tldr-pages:main Nov 25, 2022
@pixelcmtd pixelcmtd deleted the homebrew-gnu branch November 26, 2022 12:38
@pixelcmtd pixelcmtd mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel left review comments

@kbdharun kbdharun kbdharun approved these changes

@EmilyGraceSeville7cf EmilyGraceSeville7cf EmilyGraceSeville7cf approved these changes

@marchersimon marchersimon Awaiting requested review from marchersimon

@CleanMachine1 CleanMachine1 Awaiting requested review from CleanMachine1

@SethFalco SethFalco Awaiting requested review from SethFalco

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. mass changes Changes that affect multiple pages. new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pixelcmtd @kbdharun @navarroaxel @EmilyGraceSeville7cf