Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impl of std's DirEntryExt #2912

Closed
Darksonn opened this issue Oct 5, 2020 · 1 comment · Fixed by #2921
Closed

Remove impl of std's DirEntryExt #2912

Darksonn opened this issue Oct 5, 2020 · 1 comment · Fixed by #2921
Assignees
@taiki-e
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-fs Module: tokio/fs
Milestone
v0.3

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Oct 5, 2020

The trait should be copied into Tokio and use Tokio's version instead. Additionally the trait should be sealed. See #2909 and #2515 (comment).
@Darksonn Darksonn added C-bug Category: This is a bug. A-tokio Area: The main tokio crate M-fs Module: tokio/fs labels Oct 5, 2020
@taiki-e taiki-e added this to the v0.3 milestone Oct 6, 2020
@taiki-e
Copy link
Member

taiki-e commented Oct 6, 2020 •
edited
Loading

It's a breaking change to do this after 0.3 is released, so I added this to 0.3 milestone.

@taiki-e taiki-e mentioned this issue Oct 7, 2020
Merged
@taiki-e taiki-e self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-fs Module: tokio/fs
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

fs: switch to our own DirEntryExt trait
2 participants
@Darksonn @taiki-e