Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: seal OpenOptionsExt and DirBuilderExt #2909

Merged
merged 1 commit into from
Oct 4, 2020
Merged

fs: seal OpenOptionsExt and DirBuilderExt #2909

merged 1 commit into from
Oct 4, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 4, 2020

Motivation

We don't expect users to implement these extension traits. See also #2515 (comment).

Solution

@taiki-e taiki-e added A-tokio Area: The main tokio crate M-fs Module: tokio/fs labels Oct 4, 2020
@taiki-e taiki-e requested a review from Darksonn October 4, 2020 13:27
@Darksonn Darksonn added the C-maintenance Category: PRs that clean code up or issues documenting cleanup. label Oct 4, 2020
Darksonn
Darksonn approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. That's probably a good idea.

@taiki-e taiki-e merged commit 0ed4127 into tokio-rs:master Oct 4, 2020
@taiki-e taiki-e deleted the fs-seal branch October 4, 2020 15:47
@Darksonn Darksonn mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-fs Module: tokio/fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @Darksonn