-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: breaking API changes #2928
Comments
This was referenced Oct 8, 2020
Closed
This was referenced Oct 9, 2020
carllerche
pushed a commit
that referenced
this issue
Oct 9, 2020
carllerche
added a commit
that referenced
this issue
Oct 9, 2020
Switches various socket methods from &mut self to &self. This uses the intrusive waker infrastructure to handle multiple waiters. Refs: #2928
carllerche
pushed a commit
that referenced
this issue
Oct 9, 2020
zaharidichev
added a commit
to zaharidichev/tokio
that referenced
this issue
Oct 10, 2020
Can #2928 be added to the list? |
@akhilles I think you made a typo w/ your issue ref (you refed the current issue). If you have a proposal for an API change for 1.0, create a new issue for it 👍 I don't think we are going to change any of the remaining APIs, so I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tracks smaller breaking API changes that are left to make
io
Copy
should be private. (io: make Seek and Copy private #2935)Seek
should be private. (io: make Seek and Copy private #2935)ReadBuf
changes io: remaining AsyncRead / ReadBuf items #2769.net
TcpStream::poll_peek(&mut self, ...)
->&self
. (net: switch socket methods to &self #2934)TcpStream::peek(&self)
->&self
. (net: switch socket methods to &self #2934)UnixDatagram::try_send(&mut self, ...)
->&self
. (net: switch socket methods to &self #2934)UnixDatagram::try_send_to(&mut self, ...)
->&self
. (net: switch socket methods to &self #2934)UnixDatagram::try_recv(&mut self)
->&self
. (net: switch socket methods to &self #2934)UnixDatagram::try_recv_from(&mut self)
->&self
. (net: switch socket methods to &self #2934)UnixListener::accept(&mut self, ...)
->&self
. (net: switch socket methods to &self #2934)UnixListener::poll_accept(&mut self, ...)
->&self
. (net: switch socket methods to &self #2934)UnixListener::incoming(...)
-> remove for now (trackTcpListener::incoming()
)`. (net: switch socket methods to &self #2934)split
fns off ofnet
types into-util
.UCred
, at the very least make struct fields private. (net: make UCred fields private #2936)sync
Mutex::const_new()
->new()
. This may have to be conditionallyconst
w/parking_lot
feature.Mutex::lock_owned()
->tokio-util
.mpsc::Sender::closed(&mut self)
->&self
. (sync: change chanclosed(&mut self)
toclosed(&self)
#2939)mpsc::UnboundedSender::closed(&mut self)
->&self
. (sync: change chanclosed(&mut self)
toclosed(&self)
#2939)broadcast
move error types intobroadcast::error
module. (sync: move broadcast error types into broadcast::error module #2937)time
time::Delay
->time::Sleep
. (time: renameDelay
future toSleep
#2932)time::error
. (time: move error types intotime::error
#2938)The text was updated successfully, but these errors were encountered: