Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: all SocketAddr arguments should be by value #3122

Closed
carllerche opened this issue Nov 10, 2020 · 0 comments · Fixed by #3125
Closed

net: all SocketAddr arguments should be by value #3122

carllerche opened this issue Nov 10, 2020 · 0 comments · Fixed by #3125
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net
Milestone
v1.0

Comments

@carllerche
Copy link
Member

I noticed that, at least, UdpSocket::poll_send_to takes the SocketAddr by reference.
@carllerche carllerche added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Nov 10, 2020
@carllerche carllerche added this to the v1.0 milestone Nov 10, 2020
@nylonicious nylonicious mentioned this issue Nov 11, 2020
Merged
@Darksonn Darksonn added the M-net Module: tokio/net label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

net: Pass SocketAddr by value
3 participants
@carllerche @Darksonn and others