Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: Pass SocketAddr by value #3125

Merged
merged 3 commits into from
Dec 10, 2020
Merged

net: Pass SocketAddr by value #3125

merged 3 commits into from
Dec 10, 2020

Conversation

nylonicious
Copy link
Contributor

Motivation

Closes #3122.

@carllerche
Copy link
Member

Thanks! This is a breaking change, so I will hold off merging for now. We should be forking off 1.0 "soonish" though.

@nylonicious
Copy link
Contributor Author

I also updated one call to UdpSocket::poll_send_to in tokio-util, if that will be an issue I'll revert the change.

@Darksonn Darksonn added this to the v1.0 milestone Nov 11, 2020
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net labels Nov 11, 2020
@leshow leshow mentioned this pull request Nov 16, 2020
Merged
13 tasks
@taiki-e taiki-e added the S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. label Nov 20, 2020
@LucioFranco
Copy link
Member

Whats the status on this?

@Darksonn
Copy link
Contributor

I think the status is that its blocked on forking off v1.0.

@taiki-e
Copy link
Member

taiki-e commented Dec 10, 2020

triage: this is no longer blocked

@taiki-e taiki-e removed the S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. label Dec 10, 2020
@LucioFranco
Copy link
Member

@nylonicious can you rebase then we can get this merged! thanks.

@LucioFranco LucioFranco merged commit 16c2e09 into tokio-rs:master Dec 10, 2020
@LucioFranco
Copy link
Member

Thanks!

@nylonicious nylonicious deleted the socketaddr-by-value branch January 10, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

net: all SocketAddr arguments should be by value
5 participants
@nylonicious @carllerche @LucioFranco @Darksonn @taiki-e