Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timer: finish updating timer #1222

Merged
merged 21 commits into from
Jun 30, 2019
Merged

timer: finish updating timer #1222

merged 21 commits into from
Jun 30, 2019

Conversation

carllerche
Copy link
Member

@carllerche carllerche commented Jun 28, 2019 •
edited
Loading

tokio-timer was not fully updated.

#1225 tracks work that needs to be done related to helpers

Remaining

  • update tests
  • update tokio-test clock bits.
  • Get CI to run async-traits feature flags.

Follow up

  • Re-export timer from tokio.

@carllerche carllerche force-pushed the finish-updating-timer branch from 7d1d2e1 to 132e60d Compare June 28, 2019 22:26
@carllerche carllerche mentioned this pull request Jun 28, 2019
Closed
@carllerche carllerche marked this pull request as ready for review June 29, 2019 06:05
@carllerche
Copy link
Member Author

Marking as ready for review even though there is a tiny bit more work with CI... but it is late.

@rubdos rubdos mentioned this pull request Jun 29, 2019
Merged
@carllerche carllerche merged commit b2c7778 into master Jun 30, 2019
@carllerche carllerche deleted the finish-updating-timer branch July 8, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carllerche @davidbarsky