Fix: tokio_net::tcp::incoming::Incoming type not exported #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechkral
force-pushed
the
fix-incoming
branch
from
c0aa5b6 to
f060602
Compare
vojtechkral
changed the title
Incoming type not exported
|
|
vojtechkral
force-pushed
the
fix-incoming
branch
from
f060602 to
8c93478
Compare
|
ping @carllerche |
|
I'm hoping to put together a compat crate that helps bridge the gap between 0.1 and 0.2. This crate could provide I want to avoid providing it in the main crate until we know we want to commit to it. I will setup some tracking issues for |
|
Actually, lets merge this for now. |
|
We can follow up in #1549 |
carllerche
approved these changes
Oct 2, 2019
janbraiins
pushed a commit
to braiins/braiins-open
that referenced
this pull request
Apr 19, 2021
- Upgrade Tokio from 0.1.19 to 0.2.0-alpha5 - Use toolchain nightly-2019-08-21 - Using our fork of Tokio because of tokio-rs/tokio#1602 - Using pin-project to deal with pinning of struct fields - Connection::send() renamed to send_msg() to avoid conflict with StreamExt::send() - The socket split hack is still needed even in Tokio 0.2, refactored, now in split.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With tokio
0.2.0-alpha.5, We can't use theIncomingstream type in our types, because it's not exported. For the same reason, it can't be viewed in the documentation (also dead link here).Solution
pub usetheIncomingin thetcpmodule.Not sure about tests. Does it make sense to make a test for this?