net: add more impls for ToSocketAddrs #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Nov 10, 2019
tokio/src/net/addr.rs
Outdated
| @@ -58,17 +84,33 @@ impl sealed::ToSocketAddrsPriv for str { | |||
| } | |||
| } | |||
|
|
|||
| // ===== impl &'a [SocketAddr] ===== | |||
|
|
|||
| impl<'a> ToSocketAddrs for &'a [SocketAddr] where ReadyFuture<Self::Iter>: 'a {} | |||
There was a problem hiding this comment.
Hmm... this impl got E0275 error. (If I remove where clause, I got E0495 error.) So remove this impl for now.
There was a problem hiding this comment.
@taiki-e is there any intent towards adding back impl &'a [SocketAddr]? I was hoping to use it when attempting to bind on one of many SocketAddr. For now, I'm having to loop through each address manually, unless there's an alternative that I didn't see before.
There was a problem hiding this comment.
@chipsenkbeil: Filed #2604 for this. Sorry for the delayed response.
this impl got an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding impls the same as std.