sync: add mpsc::Sender::closed future
#2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
carllerche
requested changes
Sep 21, 2020
tokio/src/sync/mpsc/chan.rs
Outdated
| notify_rx_closed: Notify, | ||
|
|
||
| /// Indicates whether the receiver has been dropped | ||
| rx_closed: AtomicBool, |
There was a problem hiding this comment.
We don't want to use a new bool here. The rx closed state is tracked by the semaphore.
|
Thanks, I addressed the comments. The loom tests will be failing until #2839 is merged. |
zaharidichev
force-pushed
the
zd/add-sender-closed-future
branch
4 times, most recently
from
14379ba to
9716c82
Compare
|
Not sure why CI fails, tests pass locally |
|
I restarted CI. |
Fixes: tokio-rs#2800 Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
force-pushed
the
zd/add-sender-closed-future
branch
from
9716c82 to
19bfab1
Compare
Signed-off-by: Zahari Dichev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding closed future, makes it possible to select over closed and some other work, so that the task is woken when the channel is closed and can proactively cancel itself.
Solution
Added a mpsc::Sender::closed future that will become ready when the receiver is closed