rt: Change max_threads to max_blocking_threads
#3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Dec 17, 2020
tokio/src/runtime/builder.rs
Outdated
Comment on lines
504
to
498
| let blocking_pool = blocking::create_blocking_pool(self, self.max_threads); | ||
| let blocking_pool = blocking::create_blocking_pool(self, self.max_blocking_threads); |
There was a problem hiding this comment.
It seems like we need an additional change to the blocking pool. Maybe you need to add the number of worker threads to this one, or change the blocking pool itself?
There was a problem hiding this comment.
I don't see anywhere where we do worker_threads - max_threads to get the cap. Maybe @carllerche can chime in here?
There was a problem hiding this comment.
This should be worker_threads + max_blocking_threads I think.
There was a problem hiding this comment.
Eventually, we will create a special path for worker calls to spawn_blocking, but we don't have that yet.
|
@carllerche I made the change you requested. |
dekellum
reviewed
Dec 18, 2020
Darksonn
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2802