Update CHANGELOG.md #3336
Merged
Update CHANGELOG.md #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
requested changes
Dec 25, 2020
There was a problem hiding this comment.
Thanks for the PR.
Adding links is a good idea, but this patch seems to add links that do not work and break existing links as well.
I recommend seeing how these actually look: https://github.com/arniu/tokio/blob/patch-1/tokio/CHANGELOG.md
Link to PR and format with `prettier`
taiki-e
reviewed
Dec 25, 2020
Dedup and sort PRs by every version
Darksonn
approved these changes
Dec 26, 2020
Darksonn
approved these changes
Dec 27, 2020
taiki-e
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Link to PRs
Solution
Change
#3336to[#3336].