-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tokio 1.0 policies to contributing guide #3386
Add tokio 1.0 policies to contributing guide #3386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some nit-picks below.
Co-authored-by: Alice Ryhl <[email protected]>
Co-authored-by: Alice Ryhl <[email protected]>
Co-authored-by: Alice Ryhl <[email protected]>
@carllerche I have some related questions about what you meant in #2718, the blog post, and in the text as is re-used here:
(1): Does this mean that Tokio Maintainer will "port" (in either direction), as matter of process, bug fixes to 1.0.z patch releases for 5 years? Or upon request/need? (2): Or if that doesn't happen out of need sooner, would you accept PRs from user-contributors to do the same, at any time in the 5 year period (through 2025)? (For an old example, with less Semver constraints, see #1604.) (3) Or, does the release of 1.1.0 somehow close out support on 1.0.z? I don't think you meant (3), because of course if 1.1.0 has an MSRV increase or deprecation, then users are in a similar bind, right? Or at least, it would seem we users will want to reserve the right to do the work for (2), if we need to stay on an older minor release series for some period of time? Perhaps the answer could be some kind of an addition FAQ section that could be added to the guide, in this PR or after? |
FYI: https://rustc-dev-guide.rust-lang.org/contributing.html#issue-triage
|
Motivation
The 1.0 roadmap of #2718 and the Announcing Tokio 1.0 blog post both contain details of release and versioning policy moving forward. As discussed on discord, its helpful to contributors to have all the policies in one place.
Solution
I've tried to consolidate these appropriately in the CONTRIBUTING.md guide, and I also have made few general cosmetic changes.