Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokio 1.0 policies to contributing guide #3386

Merged

Conversation

dekellum
Copy link
Contributor

@dekellum dekellum commented Jan 6, 2021

Motivation

The 1.0 roadmap of #2718 and the Announcing Tokio 1.0 blog post both contain details of release and versioning policy moving forward. As discussed on discord, its helpful to contributors to have all the policies in one place.

Solution

I've tried to consolidate these appropriately in the CONTRIBUTING.md guide, and I also have made few general cosmetic changes.

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Jan 6, 2021
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some nit-picks below.

@dekellum
Copy link
Contributor Author

dekellum commented Jan 9, 2021

@carllerche I have some related questions about what you meant in #2718, the blog post, and in the text as is re-used here:

LTS guarantees [...] 5 years of maintenance.

(1): Does this mean that Tokio Maintainer will "port" (in either direction), as matter of process, bug fixes to 1.0.z patch releases for 5 years? Or upon request/need?

(2): Or if that doesn't happen out of need sooner, would you accept PRs from user-contributors to do the same, at any time in the 5 year period (through 2025)? (For an old example, with less Semver constraints, see #1604.)

(3) Or, does the release of 1.1.0 somehow close out support on 1.0.z?

I don't think you meant (3), because of course if 1.1.0 has an MSRV increase or deprecation, then users are in a similar bind, right? Or at least, it would seem we users will want to reserve the right to do the work for (2), if we need to stay on an older minor release series for some period of time?

Perhaps the answer could be some kind of an addition FAQ section that could be added to the guide, in this PR or after?

@Nemo157 Nemo157 mentioned this pull request Jan 9, 2021
10 tasks
@Darksonn Darksonn merged commit 8b9bb41 into tokio-rs:master Jan 12, 2021
@taiki-e
Copy link
Member

taiki-e commented Jan 28, 2021

The reason it is called E- is that the main Rust repo calls the same thing E-. As for why they call it that, no idea.

FYI: https://rustc-dev-guide.rust-lang.org/contributing.html#issue-triage

Green, E-prefixed labels explain the level of experience necessary to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants