use the tracing event name as the otel event name #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using the tracing macros and trying to explicitly set the 'name' of the event, for example:
This event will get emitted to open telemetry as an event with an empty name. The 'name' information will be completely lost. It seems common for this information to get dropped actually, see: tokio-rs/tracing#2774
Solution
In on_event I set the event name to
event.metadata().name()
which should be the name of the event that is handed down from tracing. I am unfamiliar with this code and the wider tracing/opentelemtry ecosystem so I am not sure this is a good way to solve this issue, or if this is even a real issue. I am also not sure what this change would break, and what kind of backward compatibility guarantees there might be. I have tested my use case (sending traces/events to jaeger) and can confirm that the names of events are being recorded correctly with this change.