Do not increment failure counter for successful calls #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jhalag, Thanks for your interest in this traefik plugin ! I think you pushed just a bit too much code on this PR, it makes your PR is really hare to read 😅 |
|
Apologies for that. Most of it is the package name changes I had to do to
get it to build in my test environment. I will update the PR with those
reset to original.
|
|
Hello @tomMoulard - commit has been reduced in diff-lines. I hope it is easier to read now. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail2ban/handler was incrementing fail count for all HTTP calls, not just failed calls. Add new function IsNotBanned() to allow checking of IP ban status without incrementing fail count.
Update tests to address time.Now() not matching between expected and actual. This error was present prior to this fork.
Addresses #136