Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"type" parameter to prompt defaults to int, but docs say str #327

Closed
AndydeCleyre opened this issue Jun 15, 2017 · 0 comments
Closed

"type" parameter to prompt defaults to int, but docs say str #327

AndydeCleyre opened this issue Jun 15, 2017 · 0 comments

Comments

@AndydeCleyre
Copy link
Contributor

terminal.py:111:

def prompt(question, type = int, default = NotImplemented, validator = lambda val: True):

terminal.py:117:

    :param type: The type of the answer, defaults to str

One of these should change, though I'm not sure which one. My guess would be make the default str.
AndydeCleyre added a commit to AndydeCleyre/plumbum that referenced this issue Jun 15, 2017
@AndydeCleyre
Fix tomerfiliba#327
522c1b7 
Fix tomerfiliba#327 in one of two obvious ways. prompt type defaults to str, to match docs.
@AndydeCleyre AndydeCleyre mentioned this issue Jun 15, 2017
Merged
AndydeCleyre pushed a commit to AndydeCleyre/plumbum that referenced this issue Jun 15, 2017
Add note about fix for tomerfiliba#327 (prompt's default value for ty…
b962c3d 
…pe from int -> str) to changelog
henryiii added a commit that referenced this issue Jun 15, 2017
@henryiii
Merge pull request #328 from AndydeCleyre/patch-3
de47645 
Fix #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndydeCleyre