Faster which/command lookup implementation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from the twister.python.procutils.which this function speeds up the importing of commands by a factor of 6, and which itself by a several hundred times.
This new verison is based on the original plumbum version. The main speed boost is from not enumerating every single file in each directory on the PATH. We just build the full path and rely on the OS to tell us if the file exists and we can run it.
|
The new version actual passes the tests! I had to fire up a vagrant VM and run the travis-ci instructions to run the tests. It would be nice to be able to run tests without installing the package, but I wasn't able to figure that out. |
|
@jlisee - thanks! by the way, when you submit a pull request travis automatically tests it, so there's no need to fire up a local travis. also, you can just run the tests with nose. |
tomerfiliba
added a commit
that referenced
this pull request
Nov 14, 2013
Faster which/command lookup implementation
tomerfiliba
pushed a commit
that referenced
this pull request
Nov 14, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the twister.python.procutils.which this function speeds up the
importing of commands by a factor of 6, and which itself by a several
hundred times.
This is an example fix for issue #97.
On the master branch:
With this fix