Add support for ObjectTemplate::SetAccessorProperty #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally wrote some tests for this baby :)
There's thing in the interface I'm unsure of. I expose the basic
SetAccessorProperty
which requiresFunctionTemplate
instances as input.But mostly, you don't need this instance. That would only be if you actually use the same function object in multiple places, but that's not the normal usage pattern.
So I also created a helper on top,
SetAccessorPropertyCallback
, which creates the templates. I'm unsure if this should be in the interface. I find it helpful, but I have no objection to remove it.Regarding the flags, I haven't researched what they do. I discovered, you shouldn't use
ReadOnly
. I think the only flag that is applicable for this case isDontEnum
, which I believe would prevent the property from being iterated infor . in
loops. But it's still listed byObject.getOwnPropertyNames
. But I didn't validate this, so I didn't add to the documentation.