api v2 initial support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
commented
Jan 25, 2025
tonistiigi
commented
Jan 25, 2025
crazy-max
reviewed
Jan 27, 2025
| @@ -3,6 +3,7 @@ module github.com/tonistiigi/go-actions-cache | |||
| go 1.22 | |||
|
|
|||
| require ( | |||
| github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.5.0 | |||
There was a problem hiding this comment.
We use the same dep for azblob cache on BuildKit: https://github.com/moby/buildkit/blob/81d49f78197cd471bb92ed800a4873384389bfd4/go.mod#L7
Using this version would require some changes on BuildKit: moby/buildkit#4715 (comment)
| cacheURL, _ = os.LookupEnv("ACTIONS_RESULTS_URL") | ||
| } else { | ||
| // ACTIONS_CACHE_URL=https://artifactcache.actions.githubusercontent.com/xxx/ | ||
| cacheURL, _ = os.LookupEnv("ACTIONS_CACHE_URL") |
There was a problem hiding this comment.
Seems it falls back to ACTIONS_RESULTS_URL if ACTIONS_CACHE_URL not set for v1: https://github.com/actions/toolkit/blob/1f7c2c79e034fe8a0d28006f52fc5b70f6dbb750/packages/cache/src/internal/config.ts#L22-L39
Supposedly these are fixed now but looks very flaky in practice. Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
REST API can only work in one version. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
v2-api
branch
2 times, most recently
from
d62fa2a to
0313f96
Compare
Testing commit having issue with returning ok before replication has completed. Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.