Use Base.Linking.private_libdir() for base libTracyClient
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a problem for relocatability for us to resolve the path dynamically from `dllist()` at pre-compile time, so instead we resolve it at `__init__()` by looking directly in the private libdir. Eventually, this should be moved into its own stdlib, in which case we can use the library from LibTracyClient_jll directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a problem for relocatability for us to resolve the path from
dllist()at pre-compile time, so instead we resolve it at__init__()by looking directly in the private libdir.Eventually, this should be moved into its own stdlib, in which case we can use the library from
LibTracyClient_jlldirectly.