Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searching option to listing user profiles endpoint #800

Conversation

mario-nt
Copy link
Contributor

Resolves #799

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 48.45%. Comparing base (b6e4adf) to head (da4ee5d).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/databases/mysql.rs 0.00% 7 Missing ⚠️
src/databases/sqlite.rs 0.00% 7 Missing ⚠️
src/services/user.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #800      +/-   ##
===========================================
- Coverage    48.53%   48.45%   -0.09%     
===========================================
  Files          111      111              
  Lines         8413     8427      +14     
  Branches      8413     8427      +14     
===========================================
  Hits          4083     4083              
- Misses        4192     4206      +14     
  Partials       138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mario-nt mario-nt force-pushed the 799-add-searching-option-to-listing-user-profiles-endpoint branch from 1a39a61 to da4ee5d Compare January 26, 2025 12:31
@mario-nt mario-nt marked this pull request as ready for review January 26, 2025 12:49
@mario-nt mario-nt requested a review from josecelano January 26, 2025 14:44
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mario-nt It looks good. It might be also useful to search using the email, not only the username.

@josecelano
Copy link
Member

ACK da4ee5d

@josecelano josecelano merged commit 1c1002d into torrust:develop Jan 27, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add searching option to listing user profiles endpoint
2 participants