feat(compat): Implement compat/pickBy #950
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gs18004
changed the title
| * const result = pickBy(obj, shouldPick); | ||
| * // result will be { b: 'pick' } | ||
| */ | ||
| export function pickBy<T extends Record<string, any>>( |
There was a problem hiding this comment.
Hi!
If you could add small fix here it would be great.
Function doesn't warn you if you pass null as obj, and if you do so, it will crash :)
however, lodash pickBy in that case returns {}
you can look here:
https://github.com/lodash/lodash/blob/4.17.15/lodash.js#L13582
Please add same here, or some warning that obj can't be null.
There was a problem hiding this comment.
Thank you for your suggestion! I fixed this problem. Would you check it?
There was a problem hiding this comment.
Great! Thank you very much)
Maybe add some tests for it? I'm not sure.
And wait for approval from someone from repo)
There was a problem hiding this comment.
Sure! I will add some tests :)
I added the
pickByfunction to compat, which behaviors similar to Lodash'spickBy:the second param of the function is optional.
Thanks to: #946