Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support react 19 #95

Merged
merged 9 commits into from
Dec 15, 2024
Merged

feat: support react 19 #95

merged 9 commits into from
Dec 15, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Dec 12, 2024

Description

Related Issue: Fixes # (issue_number)

Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 3:32pm

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: f798c79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
overlay-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (a04c030) to head (f798c79).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files          11       11           
  Lines         243      243           
  Branches       49       49           
=======================================
  Hits          198      198           
  Misses         43       43           
  Partials        2        2           
Components Coverage Δ
overlay-kit 81.48% <ø> (ø)

Copy link
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jungpaeng jungpaeng merged commit 59f2917 into main Dec 15, 2024
9 of 10 checks passed
@jungpaeng jungpaeng deleted the feat/support-react19 branch December 15, 2024 15:29
@github-actions github-actions bot mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants