Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect page num when draft is true #125

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

enklht
Copy link
Contributor

@enklht enklht commented Nov 28, 2024

I removed one line to correctly handle page numbering when draft mode is true. This change resolves issue #121.
I've tested it to ensure pagination works as expected in draft mode with the example given in #121.
Ready for review!

@OrangeX4 OrangeX4 added the bug Something isn't working label Nov 29, 2024
@OrangeX4
Copy link
Member

I didn't think it should break the consistency between normal mode and handout mode, so I made a small change.

@OrangeX4 OrangeX4 merged commit ad9d27b into touying-typ:main Nov 29, 2024
@enklht enklht deleted the fix_draft_page_num branch November 30, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect page numbering when handout mode is on and if the page has #pause
3 participants