Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metropolis slide's header to return content if title is specified #126

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix: metropolis slide's header to return content if title is specified #126

merged 1 commit into from
Dec 1, 2024

Conversation

enklht
Copy link
Contributor

@enklht enklht commented Dec 1, 2024

I discovered a bug in the metropolis theme where the header was returning the function itself instead of calling it. This causes an error when trying to specify the slide title.

minimal working example

#import "@preview/touying:0.5.3": *
#import themes.metropolis: *

#show: metropolis-theme

#slide(title: "section with a title")[
  error!
]

@OrangeX4
Copy link
Member

OrangeX4 commented Dec 1, 2024 •
edited
Loading

It's a bug indeed, thanks

@OrangeX4 OrangeX4 merged commit d779439 into touying-typ:main Dec 1, 2024
@enklht enklht deleted the fix-metropolis-header branch December 1, 2024 06:01
enklht added a commit to enklht/touying that referenced this pull request Dec 6, 2024
@enklht @enkaito
fix: metropolis slide's header to return content if title is specified (
8bdd5ed 
touying-typ#126)
@OrangeX4 OrangeX4 mentioned this pull request Dec 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrangeX4 OrangeX4 OrangeX4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enklht @OrangeX4 @enkaito