Fixes 119 #121
Merged
Fixes 119 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) It turned out that for islands that do not satisfy the minimal-width criterion, which is a requirement for a realistic mmoments computation, no error bars were computed at all. The solution chosen here is to use the "extract.ParamSet()._error_bars_from_moments" method for thin detections, since they will likely provide a better (larger) estimate of the true error bars than "extract.ParamSet()._condon_formulae", which is applied after a successful Gaussian fit. This is an ad hoc solution, since "extract.ParamSet()._error_bars_from_moments" may still be underestimating the true error bars for thin detections, but it is in agreement with vectorized source processing as in "fitting.moments_enhanced". To implement this, "extract.ParamSet" needs the "thin_detection" attribute. 2) Grammar correction. 3) Line break to stay within 80 characters per line.
Add pixel coordinates of source centres, signal-to-noise ratios and reduced chi-squared statistics to output csv file by default.
"pyse" is a Python script, not a shell script, therefore it should have the ".py" extension.
"six" Python 2->3 compatibility library not needed. "print_" was used, but "print()" from Python 3 should serve our needs.
Without the repeated "%f", which is error prone. "%f" should correspond to ".6f".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
but not yet as the most sustainable solution, that is why we leave #74 open.
"x", "y", "sig" and "reduced_chisq" are now part of the output .csv file by default.
"pyse" --> "pyse.py"
"print_" from "six" no longer needed.
It also fixes this bug for "thin" detections i.e. that most errors were zero.