Fixes 122 #125
Merged
Fixes 122 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"measuring" is a more appropriate name for this module than "fitting", since, e.g. moments analysis does not include any kind of fitting (as in least-squares fitting).
The "fitting" module has been renamed to "measuring", this requires some adjustments, particularly when functions are called.
Simple function for replacing initial gaussian args by fixed values. It was used twice, that is why we created this function.
1) Replace the two code snippets with calls to a new function in the "utils" module: "complement_gaussian_args". 2) Comment does not relect the code below it, therefore removed.
1) "complement" is more accurate than "replace". 2) The docstring from ChatGPT was completely rewritten, therefore the comment does not apply. 3) Clarification added, "initial_params" and "fixed_params" should complement each other, therefore the word "replace" is not appropriate.
|
The creation of the "initial" list was left unchanged, it seemed not worth the effort of turning it into a separate function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
"measuring" is a more appropriate name for this module than "fitting".