Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprioritize jobs which are allowed to fail #59

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Deprioritize jobs which are allowed to fail #59

merged 1 commit into from
Jan 19, 2017

Conversation

BanzaiMan
Copy link
Contributor

In other words, enqueue jobs which are not allowed to fail first before those which are.

This is not perfect, as there are multiple threads enqueuing the jobs, but it should be good enough for a lot of cases.

@BanzaiMan
Copy link
Contributor Author

This resolves travis-ci/travis-ci#1092.

@BanzaiMan
Copy link
Contributor Author

Before:

build__1339_-banzaiman_travis_staging_test-_travis_ci

After:

build__1339_-banzaiman_travis_staging_test-_travis_ci

joecorcoran
joecorcoran approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@joecorcoran joecorcoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Never seen Enum#partition before either. 🚀

@BanzaiMan BanzaiMan merged commit dbe34c8 into master Jan 19, 2017
@BanzaiMan BanzaiMan deleted the ha-deprioritize-allow_failures branch January 19, 2017 15:13
@BanzaiMan BanzaiMan mentioned this pull request May 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecorcoran joecorcoran joecorcoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BanzaiMan @joecorcoran