Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/seed: Add SLIP-0077 derivation to Keychain #398

Merged
merged 1 commit into from
Aug 31, 2019
Merged

core/seed: Add SLIP-0077 derivation to Keychain #398

merged 1 commit into from
Aug 31, 2019

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Aug 10, 2019 •
edited
Loading

@prusnak prusnak requested a review from andrewkozlik August 10, 2019 17:09
@prusnak
Copy link
Member

prusnak commented Aug 30, 2019

@romanz is there a strong reason why to introduce Slip77 class? If not, it might be more consistent with the rest to just introduce two new Keychain methods:

  • derive_slip77_blinding_private_key
  • derive_slip77_blinding_public_key

What do you think?

@romanz
core/seed: add SLIP-0077 derivation to Keychain
95c224d 
Following trezor#66 and trezor#317, it would allow deriving confidential addresses and
unblinding confidential transactions' outputs.
@romanz
Copy link
Contributor Author

romanz commented Aug 30, 2019 •
edited
Loading

is there a strong reason why to introduce Slip77 class?

Not really :)
Fixed and force-pushed.

@romanz romanz changed the title core/seed: Add SLIP-0077 derivation using Keychain wrapper core/seed: Add SLIP-0077 derivation to Keychain Aug 31, 2019
@prusnak prusnak merged commit 680e18a into trezor:master Aug 31, 2019
@prusnak
Copy link
Member

prusnak commented Aug 31, 2019

Thanks

@romanz romanz deleted the elements/slip77 branch August 31, 2019 18:34
romanz added a commit to romanz/trezor-firmware that referenced this pull request Aug 31, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
6878d72 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
@romanz romanz mentioned this pull request Aug 31, 2019
Closed
romanz added a commit to romanz/trezor-firmware that referenced this pull request Sep 1, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
30b4c3f 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Sep 21, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
da7eea9 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Nov 6, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
1e9563b 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Nov 20, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
03a5932 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Dec 13, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
b980f3b 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Dec 18, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
4735a0b 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Dec 22, 2019
@romanz
elements: derive confidential addresses using SLIP-0077
bfa6e20 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Jan 4, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
d394e4f 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Jan 4, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
b3a55dc 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Jan 4, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
d2788eb 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Jan 18, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
682bdad 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Jan 18, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
252cdcc 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Feb 13, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
560fb49 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Feb 13, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
98e4fc5 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
romanz added a commit to romanz/trezor-firmware that referenced this pull request Feb 21, 2020
@romanz
elements: derive confidential addresses using SLIP-0077
b854b64 
Following trezor#66 and trezor#398, it would allow receiving confidential
transactions to addresses generated on the devices.

Blinding, unblinding and signing will be added in separate PRs.
@matejcik
Copy link
Contributor

matejcik commented May 4, 2020

Heads-up: i'm removing the slip0077 methods from the Keychain class in #959. ISTM that instead of methods of Keychain, these should be helper functions of the Elements signer, as they are only using the public derive() method.

@romanz
Copy link
Contributor Author

romanz commented May 6, 2020

Sound good, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkozlik andrewkozlik andrewkozlik approved these changes

Assignees

@andrewkozlik andrewkozlik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanz @prusnak @matejcik @andrewkozlik