Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service monitor API version override #266

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

cgpoh
Copy link
Contributor

@cgpoh cgpoh commented Nov 28, 2024

This feature enables users to override the Service Monitor API version if they are using Azure managed prometheus which uses azmonitoring.coreos.com/v1 instead of the default monitoring.coreos.com/v1.

Copy link

cla-bot bot commented Nov 28, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Nov 28, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Nov 29, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick nineinchnick added the enhancement New feature or request label Dec 4, 2024
@cgpoh
Copy link
Contributor Author

cgpoh commented Dec 5, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2024
Copy link

cla-bot bot commented Dec 5, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash commits, and remove the chore: prefix.

@cgpoh
Copy link
Contributor Author

cgpoh commented Dec 5, 2024

Thanks @nineinchnick for your review! Commits sqaush and prefix removed.

@nineinchnick nineinchnick merged commit d3c79ae into trinodb:main Dec 5, 2024
10 checks passed
@cgpoh cgpoh deleted the svc-monitor-api branch December 5, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants