Release Trino Gateway chart 1.13.0 #270
Conversation
|
Trino Gateway's Docker image 13 is not available yet: https://hub.docker.com/r/trinodb/trino-gateway/tags |
I know .. this is in preparation to get things ready.. |
mosabua
force-pushed
the
trino-gateway-13
branch
from
5d6cb85 to
1fb016a
Compare
|
I pushed a commit again so this build runs again since the docker container is released .. but there are failures.. what am I missing @nineinchnick and @willmostly ? |
|
Nevermind .. I think I found it. |
mosabua
force-pushed
the
trino-gateway-13
branch
from
1fb016a to
a161ea9
Compare
|
You need to commit the updated Readme. See the main repo readme on how to set up a precommit hook to do this automatically |
mosabua
force-pushed
the
trino-gateway-13
branch
5 times, most recently
from
9f8256a to
9d46ff9
Compare
mosabua
force-pushed
the
trino-gateway-13
branch
from
9d46ff9 to
deccd40
Compare
For Trino Gateway 13
mosabua
force-pushed
the
trino-gateway-13
branch
from
deccd40 to
53899f2
Compare
|
Finally.. it passed now. |
| @@ -2,15 +2,15 @@ apiVersion: v2 | |||
| name: trino-gateway | |||
| description: A Helm chart for Trino Gateway | |||
| type: application | |||
| version: "0.12.0" | |||
| appVersion: "12" | |||
| version: "1.13.0" | |||
There was a problem hiding this comment.
Why do we increment a major version?
There was a problem hiding this comment.
Having 0 as the major version might be understood the chart is unstable, or not ready for production use, which is not accurate, and might confuse some users. We agreed with @mosabua to bump major versions for both Trino and Trino Gateway to 1. So there are no breaking changes here, we just want to mark a stable release from this point forward.
There was a problem hiding this comment.
Our chart used to have full major versions so 10.0.0, 11.0.0 .. and when we changed to the chart repo here it was changed to 0.x .. however we (Trino Gateway maintainers and @nineinchnick feel that this is misleading. The chart is totally usable for production so the version should be > 1.0 .. hence we are switching 1.x with x being the Trino Gateway version now .. and if we cut chart releases in between we go minor update..
We also plan to upgrade the trino chart to be >1 .. and the go client ..
For Trino Gateway 13
Also @willmostly