Allow list syntax for exchangeManager baseDir targets #284
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Please squash both commits. Normally I'd try to do that, since I see I'll merge this as soon as the CLA clears out. |
This change will allow using list syntax of exchangeManager base-directories which is more common and understandable with Helm charts.
Trino allows specifying multiple spooling targets for exchageManager separated by commas when using main cloud providers or any S3 compatible protocol (example: s3://bucket1,s3://bucket2,s3://bucket3). With current trinodb/chart we have to specify them within values as a single line for baseDir:
server:
exchangeManager:
name: "filesystem"
baseDir: "s3://exchange-spooling-bucket-1,s3://exchange-spooling-bucket-2"
Which translates to:
exchange-manager.properties: |
exchange-manager.name=filesystem
exchange.base-directories=s3://exchange-spooling-bucket-1,s3://exchange-spooling-bucket-2
This change allows a more clean listing within values:
server:
exchangeManager:
name: "filesystem"
baseDir:
- "s3://exchange-spooling-bucket-1"
- "s3://exchange-spooling-bucket-2"
Which translates to the same:
exchange-manager.properties: |
exchange-manager.name=filesystem
exchange.base-directories=s3://exchange-spooling-bucket-1,s3://exchange-spooling-bucket-2
It will not break any existing listings as stating them the same way as before in a single line will result in exchange.base-directories within a single line.
Documentation for setting up fault tolerant execution: https://trino.io/docs/current/admin/fault-tolerant-execution.html
Chart documentation has been also updated. Default usage example has been changed to a listed view with a minor clean up of the overall description.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Done, thanks! |
|
Hi @nineinchnick, CLA should be cleared now |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This change will allow using list syntax of exchangeManager base-directories which is more common and understandable with Helm charts.
Trino allows specifying multiple spooling targets for exchageManager separated by comma when using main cloud providers or any S3 compatible protocol (example: s3://bucket1,s3://bucket2,s3://bucket3). With current trinodb/charts we have to specify them within values as a single line for baseDir:
Which translates to:
This change allows a more clean listing within values:
Which translates to the same:
It will not break any existing listings as stating them the same way as before in a single line will result in exchange.base-directories within a single line.
Documentation for setting up fault tolerant execution: https://trino.io/docs/current/admin/fault-tolerant-execution.html