Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove extra files from release package #728

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix: remove extra files from release package #728

merged 1 commit into from
Nov 19, 2024

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Nov 19, 2024 •
edited
Loading

After shifting config files to TS these were now being included in the release package. This commit removes them from the release package.

Also addresses the src nested under dist

@regadas
Fix: remove extra files from release package
b939a5b 
After shifting config files to TS these were now being included in the release package.
This commit removes them from the release package.
@cla-bot cla-bot bot added the cla-signed label Nov 19, 2024
@regadas regadas requested a review from mosabua November 19, 2024 04:28
@regadas regadas mentioned this pull request Nov 19, 2024
Closed
regadas
regadas commented Nov 19, 2024
View reviewed changes
Copy link
Contributor Author

@regadas regadas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling the trigger as this affects the latest release hmm cant 😄

@regadas regadas requested a review from nineinchnick November 19, 2024 04:34
mosabua
mosabua approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Probably should cut another release ;-)

@regadas regadas merged commit 71144aa into trinodb:main Nov 19, 2024
4 checks passed
@regadas regadas deleted the fix_release branch November 19, 2024 05:20
@regadas
Copy link
Contributor Author

regadas commented Nov 19, 2024

Thanks for the review ❤️ this one slipped through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@nineinchnick nineinchnick nineinchnick approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regadas @mosabua @nineinchnick