Install compiled artifacts

Multi-Release JARs are causing error_prone/javadoc/surefire to use the latest compilation unit while resolving dependencies for other modules.
trinodb · Feb 27, 2025 · 518256b · 518256b
1 parent be9dfef
commit 518256b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -82,7 +82,7 @@ jobs:
       - name: Maven Checks
         run: |
           export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
-          $MAVEN clean verify -B --strict-checksums -V -T 1C -DskipTests -P ci
+          $MAVEN clean install verify -B --strict-checksums -V -T 1C -DskipTests -P ci
       - name: Remove Trino from local Maven repo to avoid caching it
         # Avoid caching artifacts built in this job, cache should only include dependencies
         if: steps.cache.outputs.cache-hit != 'true' && matrix.cache == 'true'
@@ -197,7 +197,7 @@ jobs:
         run: |
           export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
           # Skip checks, these are run in `maven-checks` job and e.g. checkstyle is expensive.
-          $MAVEN ${MAVEN_TEST} -T 1C clean compile test-compile -DskipTests -Dair.check.skip-all=true ${MAVEN_GIB} -Dgib.buildUpstream=never -P errorprone-compiler \
+          $MAVEN ${MAVEN_TEST} -T 1C clean compile test-compile install -DskipTests -Dair.check.skip-all=true ${MAVEN_GIB} -Dgib.buildUpstream=never -P errorprone-compiler \
             -pl '!:trino-docs,!:trino-server'
 
   test-jdbc-compatibility:
@@ -328,7 +328,7 @@ jobs:
       - name: Maven Tests
         id: tests
         run: |
-          $MAVEN test ${MAVEN_TEST} -pl '
+          $MAVEN test install ${MAVEN_TEST} -pl '
             !:trino-base-jdbc,
             !:trino-bigquery,
             !:trino-cassandra,

diff --git a/client/trino-client/pom.xml b/client/trino-client/pom.xml
@@ -157,7 +157,20 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <executions>
-                    <!-- Order is important - we want to attach JDK 11 to the reactor -->
+                    <execution>
+                        <id>compile-java-11</id>
+                        <goals>
+                            <goal>compile</goal>
+                        </goals>
+                        <phase>compile</phase>
+                        <configuration>
+                            <multiReleaseOutput>true</multiReleaseOutput>
+                            <release>11</release>
+                            <compileSourceRoots>
+                                <compileSourceRoot>${project.basedir}/src/main/java</compileSourceRoot>
+                            </compileSourceRoots>
+                        </configuration>
+                    </execution>
                     <execution>
                         <id>compile-java-22</id>
                         <goals>